linux-kernel - Re: [PATCH 3/3] selftests/zram: Adapt the situation that /dev/zram0 is being used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ec24b9a-4b98-ca31-9862-4b2d2df4b50e@linuxfoundation.org>
Date:   Tue, 25 Jan 2022 13:40:25 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Yang Xu <xuyang2018.jy@...itsu.com>,
        linux-kselftest@...r.kernel.org, shuah@...nel.org
Cc:     linux-kernel@...r.kernel.org, naresh.kamboju@...aro.org,
        aleksei.kodanev@...l-sw.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 3/3] selftests/zram: Adapt the situation that /dev/zram0
 is being used

On 12/15/21 2:56 AM, Yang Xu wrote:
> On some linux distributions, if it used /dev/zram0 as default by zram-generate
> service, then this case will fail or report EBUSY.
> 
> To fix this, use hot_add/hot_remove interface. Also, move module check code into
> zram_load from zram.sh. We can use /sys/class/zram-control to detect the
> module whether existed.
> 
> After this patch, we still run case pass even /dev/zram0 is being used.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@...itsu.com>
> ---
>   tools/testing/selftests/zram/zram.sh     | 16 +----
>   tools/testing/selftests/zram/zram01.sh   |  2 +-
>   tools/testing/selftests/zram/zram_lib.sh | 75 ++++++++++++------------
>   3 files changed, 41 insertions(+), 52 deletions(-)
> 

This patch looks good to me. A few checkpatch warns to fix and also
it probably depends on the other two patches in this series.

Please fix and send v2 for all 3 patches.

thanks,
-- Shuah