linux-kernel - Re: [PATCH] dm mpath: fix missing blk_account_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfBgbLVOPWEy60bH@infradead.org>
Date:   Tue, 25 Jan 2022 12:41:16 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     snitzer@...hat.com, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH] dm mpath: fix missing blk_account_io_done() in error path

On Tue, Jan 25, 2022 at 08:26:54PM +0800, Yu Kuai wrote:
> If blk_mq_request_issue_directly() failed from
> blk_insert_cloned_request(), the request will be accounted start.
> Currently, blk_insert_cloned_request() is only called by dm, and such
> request won't be accounted done by dm.
> 
> In normal path, io will be accounted start from blk_mq_bio_to_request(),
> when the request is allocated, and such io will be accounted done from
> __blk_mq_end_request_acct() whether it succeeded or failed. Thus add
> blk_account_io_done() to fix the problem.

The patch looks good, but the subject is incorrect, this is not in
dm-mpath but in the block layer.