[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <31ebfa0a-5e2d-332c-cbe1-22bdfeee8cd9@linuxfoundation.org>
Date: Tue, 25 Jan 2022 13:51:29 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Viresh Kumar <viresh.kumar@...aro.org>,
Nícolas F. R. A. Prado
<nfraprado@...labora.com>
Cc: Shuah Khan <shuah@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...labora.com, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: cpufreq: Write test output to stdout as well
On 1/16/22 11:41 PM, Viresh Kumar wrote:
> On 14-01-22, 18:21, Nícolas F. R. A. Prado wrote:
>> Use 'tee' to send the test output to stdout in addition to the current
>> output file. This makes the output easier to handle in automated test
>> systems and is superior to only later dumping the output file contents
>> to stdout, since this way the test output can be interleaved with other
>> log messages, like from the kernel, so that chronology is preserved,
>> making it easier to detect issues.
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>> ---
>> tools/testing/selftests/cpufreq/main.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/cpufreq/main.sh b/tools/testing/selftests/cpufreq/main.sh
>> index 31f8c9a76c5f..60ce18ed0666 100755
>> --- a/tools/testing/selftests/cpufreq/main.sh
>> +++ b/tools/testing/selftests/cpufreq/main.sh
>> @@ -194,5 +194,5 @@ prerequisite
>>
>> # Run requested functions
>> clear_dumps $OUTFILE
>> -do_test >> $OUTFILE.txt
>> +do_test | tee -a $OUTFILE.txt
>> dmesg_dumps $OUTFILE
>
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
Thank you. Applied to linux-kselftest fixes for rc2/3
thanks,
-- Shuah
Powered by blists - more mailing lists