linux-kernel - Re: [PATCH v5 2/2] Bluetooth: hci_h5: Add power reset via gpio in h5_btrtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <05BB86B6-9E4B-447F-91A3-34224703176C@holtmann.org>
Date:   Tue, 25 Jan 2022 22:42:09 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Vyacheslav Bocharov <adeep@...ina.in>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        BlueZ <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Rudi Heitbaum <rudi@...tbaum.com>
Subject: Re: [PATCH v5 2/2] Bluetooth: hci_h5: Add power reset via gpio in
 h5_btrtl_open

Hi Vyachselav,

> Add power reset for bluetooth via enable-gpios in h5_btrtl_open function.
> 
> Signed-off-by: Vyacheslav Bocharov <adeep@...ina.in>
> ---
> 
> While testing the RTL8822CS SDIO WiFi/BT adapter, I found that in some
> cases the kernel could not initialize it. However, manually resetting the
> adapter via gpio allows it to start correctly.
> Apparently at system start the adapter is in an undefined state (including
> the unknown state of gpio after starting uboot). A forced reset helps to
> initialize the adapter in most cases. Experimentally it was found that
> 100ms is enough to reset.

if you put this here, then this information is lost. So move it to the commit message.

Regards

Marcel