linux-kernel - Re: [PATCH v4 50/66] mm/gup: Use maple tree navigation instead of linked list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220125215408.ltkna5toordacwfk@revolver>
Date:   Tue, 25 Jan 2022 21:54:15 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Vlastimil Babka <vbabka@...e.cz>
CC:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Rik van Riel <riel@...riel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michel Lespinasse <walken.cr@...il.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Minchan Kim <minchan@...gle.com>,
        Joel Fernandes <joelaf@...gle.com>,
        Rom Lemarchand <romlem@...gle.com>
Subject: Re: [PATCH v4 50/66] mm/gup: Use maple tree navigation instead of
 linked list

* Vlastimil Babka <vbabka@...e.cz> [220119 12:39]:
> On 12/1/21 15:30, Liam Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
> 
> Empty message.
> 
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> > ---
> >  mm/gup.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/mm/gup.c b/mm/gup.c
> > index 2c51e9748a6a..60892e5df6a2 100644
> > --- a/mm/gup.c
> > +++ b/mm/gup.c
> > @@ -1570,7 +1570,6 @@ int __mm_populate(unsigned long start, unsigned long len, int ignore_errors)
> >  	long ret = 0;
> >  
> >  	end = start + len;
> > -
> >  	for (nstart = start; nstart < end; nstart = nend) {
> >  		/*
> >  		 * We want to fault in pages for [nstart; end) address range.
> > @@ -1579,10 +1578,10 @@ int __mm_populate(unsigned long start, unsigned long len, int ignore_errors)
> >  		if (!locked) {
> >  			locked = 1;
> >  			mmap_read_lock(mm);
> > -			vma = find_vma(mm, nstart);
> > +			vma = find_vma_intersection(mm, start, end);
> 
> Is it ok to use start instead of nstart? At least theoretically,
> populate_vma_page_range() called later can reset locked to 0, so !locked
> doesn't guarantee we are in the first iteration?

It is not okay to use start instead of nstart, I will fix this patch.

> 
> >  		} else if (nstart >= vma->vm_end)
> > -			vma = vma->vm_next;
> > -		if (!vma || vma->vm_start >= end)
> > +			vma = find_vma(mm, vma->vm_end);
> > +		if (!vma)
> >  			break;
> >  		/*
> >  		 * Set [nstart; nend) to intersection of desired address
>