linux-kernel - [PATCH 4.19 236/239] mtd: nand: bbt: Fix corner case in bad block table handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220124183950.604686824@linuxfoundation.org>
Date:   Mon, 24 Jan 2022 19:44:34 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Patrick Doyle <pdoyle@...bot.com>,
        Richard Weinberger <richard@....at>,
        Yoshio Furuyama <ytc-mb-yfuruyama7@...xia.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Frieder Schrempf <frieder.schrempf@...tron.de>
Subject: [PATCH 4.19 236/239] mtd: nand: bbt: Fix corner case in bad block table handling

From: Doyle, Patrick <pdoyle@...bot.com>

commit fd0d8d85f7230052e638a56d1bfea170c488e6bc upstream.

In the unlikely event that both blocks 10 and 11 are marked as bad (on a
32 bit machine), then the process of marking block 10 as bad stomps on
cached entry for block 11.  There are (of course) other examples.

Signed-off-by: Patrick Doyle <pdoyle@...bot.com>
Reviewed-by: Richard Weinberger <richard@....at>
Signed-off-by: Yoshio Furuyama <ytc-mb-yfuruyama7@...xia.com>
[<miquel.raynal@...tlin.com>: Fixed the title]
Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Frieder Schrempf <frieder.schrempf@...tron.de>
Link: https://lore.kernel.org/linux-mtd/774a92693f311e7de01e5935e720a179fb1b2468.1616635406.git.ytc-mb-yfuruyama7@kioxia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/mtd/nand/bbt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/nand/bbt.c
+++ b/drivers/mtd/nand/bbt.c
@@ -123,7 +123,7 @@ int nanddev_bbt_set_block_status(struct
 		unsigned int rbits = bits_per_block + offs - BITS_PER_LONG;
 
 		pos[1] &= ~GENMASK(rbits - 1, 0);
-		pos[1] |= val >> rbits;
+		pos[1] |= val >> (bits_per_block - rbits);
 	}
 
 	return 0;