linux-kernel - Re: [PATCHv4] psi: fix possible trigger missing in the window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpEGUH0SDwP9EJ-uA52R7j3pcVXa+gJX3=QtEhJQ5ig6KA@mail.gmail.com>
Date:   Wed, 26 Jan 2022 08:44:10 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Johannes Weiner <hannes@...xchg.org>
Cc:     Huangzhaoyang <huangzhaoyang@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Zhaoyang Huang <zhaoyang.huang@...soc.com>,
        Ingo Molnar <mingo@...hat.com>, linux-mm <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv4] psi: fix possible trigger missing in the window

On Tue, Jan 25, 2022 at 6:40 AM Johannes Weiner <hannes@...xchg.org> wrote:
>
> On Tue, Jan 25, 2022 at 02:56:58PM +0800, Huangzhaoyang wrote:
> > From: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> >
> > When a new threshold breaching stall happens after a psi event was
> > generated and within the window duration, the new event is not
> > generated because the events are rate-limited to one per window. If
> > after that no new stall is recorded then the event will not be
> > generated even after rate-limiting duration has passed. This is
> > happening because with no new stall, window_update will not be called
> > even though threshold was previously breached. To fix this, record
> > threshold breaching occurrence and generate the event once window
> > duration is passed.
> >
> > Suggested-by: Suren Baghdasaryan <surenb@...gle.com>
> > Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
>
> Acked-by: Johannes Weiner <hannes@...xchg.org>

Looks good. Thanks!

Acked-by: Suren Baghdasaryan <surenb@...gle.com>