linux-kernel - Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices using command line options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfGMsujnTxIxlXp4@kroah.com>
Date:   Wed, 26 Jan 2022 19:02:26 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Alfasys <alfred@...asys.se>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Damian Hobson-Garcia <dhobsong@...l.co.jp>
Subject: Re: [PATCH 001/001] UIO: allow binding uio_dmem_genirq to devices
 using command line options

On Sat, Jan 15, 2022 at 04:42:02PM +0000, Alfasys wrote:
> Add an option to bind the uio_dmem_genirq driver to a given device
> using command line options.
> Make uio_dmem_genirq match uio_pdrv_genirq functionality added in
> commit 05c3e0bb5629 ("UIO: allow binding uio_pdrv_genirq.c to devices 
> 
> using command line option")
> 
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Damian Hobson-Garcia <dhobsong@...l.co.jp>
> Signed-off-by: Alfred Patriksson <alfred@...asys.se>
> 
> ---
> 
> git diff c9e6606c7fe92 #(tag: v5.16-rc8)
> diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c
> index 6b5cfa5b0673..7f6c9b594dd4 100644
> --- a/drivers/uio/uio_dmem_genirq.c
> +++ b/drivers/uio/uio_dmem_genirq.c
> @@ -317,10 +317,13 @@ static const struct dev_pm_ops uio_dmem_genirq_dev_pm_ops = {
>  };
>  
> 
>  #ifdef CONFIG_OF
> -static const struct of_device_id uio_of_genirq_match[] = {
> -       { /* empty for now */ },
> +static struct of_device_id uio_of_genirq_match[] = {
> +       { /* This is filled with module_parm */ },
> +       { /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
> +module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");

I do not want to add new module parameters, this is not the 1990's
anymore.

thanks,

greg k-h