linux-kernel - Re: [RESEND][PATCH] Documentation: added order requirement for ima

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64bb3746-07b4-aad4-7ee0-dccda6c7d4e1@huawei.com>
Date:   Wed, 26 Jan 2022 10:32:47 +0800
From:   "Guozihua (Scott)" <guozihua@...wei.com>
To:     Jonathan Corbet <corbet@....net>, <zohar@...ux.ibm.com>
CC:     <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <roberto.sassu@...wei.com>, <wangweiyang2@...wei.com>,
        <xiujianfeng@...wei.com>, <linux-integrity@...r.kernel.org>
Subject: Re: [RESEND][PATCH] Documentation: added order requirement for
 ima_hash=



On 2022/1/26 8:14, Jonathan Corbet wrote:
> GUO Zihua <guozihua@...wei.com> writes:
> 
>> From: Guo Zihua <guozihua@...wei.com>
>>
>> Commandline parameter ima_hash= and ima_template= has order requirement
>> for them to work correctly together. Namely ima_hash= must be
>> specified after ima_template=, otherwise ima_template= will be ignored.
>>
>> The reason is that when handling ima_hash=, ima template would be set to
>> the default value if it has not been initialized already, and that value
>> cannot be changed afterwards by ima_template=.
>>
>> This patch adds this limitation to the documentation.
>>
>> Reviewed-by: Roberto Sassu <roberto.sassu@...wei.com>
>> Signed-off-by: Guo Zihua <guozihua@...wei.com>
> 
> I've applied this, but I'm wondering: where did this review take place?
> I can't find it on the lists...
> 
> Thanks,
> 
> jon
> .

Hi Jonathan,

Thank you very much and sorry for the confusion here. The reviewed by is 
more like a face-to-face peer review and I would like to mention that in 
the patch. If this is problematic I would stop doing that from now on.

-- 
Best
GUO Zihua