Message-ID: <3887fe1b-58ac-902d-a4ef-1f8825d55aa6@csgroup.eu>
Date:   Wed, 26 Jan 2022 19:18:42 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ralph Siemsen <ralph.siemsen@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: at25 eeprom driver: NULL pointer dereference (bisected to
 af40d16042d6 ("Merge v5.15-rc5 into char-misc-next"))

Getting below Oops on boot.

v5.16 is OK, v5.17-rc1 has the problem

Bisected to af40d16042d6 ("Merge v5.15-rc5 into char-misc-next"), bisect 
log after the oops dump.

I'm a bit puzzled to end up on a merge commit, that commit doesn't show 
any diff with 'git show' but has a huge list of changes with 'git show 
--stat'. I must be missing something.

Anyway at it's commit message mentions AT25 explicitely, it still may be 
related.

Any idea of what the problem can be ?


[    4.435172] BUG: Kernel NULL pointer dereference on write at 0x00000020
[    4.441701] Faulting instruction address: 0xc005d030
[    4.446612] Oops: Kernel access of bad area, sig: 11 [#1]
[    4.451942] BE PAGE_SIZE=16K PREEMPT CMPC885
[    4.456167] CPU: 0 PID: 1 Comm: swapper Not tainted 
5.17.0-rc1-s3k-dev-02049-ga676a9326655 #853
[    4.464767] NIP:  c005d030 LR: c03ad3d4 CTR: 00000000
[    4.469757] REGS: c902baa0 TRAP: 0300   Not tainted 
(5.17.0-rc1-s3k-dev-02049-ga676a9326655)
[    4.478190] MSR:  00009032 <EE,ME,IR,DR,RI>  CR: 35339393  XER: 80003100
[    4.484904] DAR: 00000020 DSISR: c2000000
[    4.484904] GPR00: c03ad3a4 c902bb60 c20f4000 00000020 c085cf1c 
c13667a8 c902bb68 c20f4000
[    4.484904] GPR08: 00000000 00000000 c2019b00 9b616b00 35339395 
00000000 c0004b1c 00000000
[    4.484904] GPR16: 00000000 00000000 00000000 00000001 c0860000 
c0863794 c08637a0 c08637ac
[    4.484904] GPR24: c08637b8 c7ffd65c c07885b0 c902bb7c ffffffc3 
c1249308 c2390c00 00000000
[    4.523544] NIP [c005d030] __mutex_init+0x4/0x18
[    4.528107] LR [c03ad3d4] at25_probe+0x94/0x5bc
[    4.532584] Call Trace:
[    4.534991] [c902bb60] [c03ad3a4] at25_probe+0x64/0x5bc (unreliable)
[    4.541274] [c902bba0] [c039f190] really_probe+0x178/0x46c
[    4.546696] [c902bbc0] [c039e030] driver_probe_device+0xcc/0x12c
[    4.552634] [c902bbe0] [c039e228] __device_attach_driver+0xb8/0x164
[    4.558831] [c902bc00] [c039c1bc] bus_for_each_drv+0x80/0xd0
[    4.564424] [c902bc30] [c039e788] __device_attach+0x10c/0x160
[    4.570105] [c902bc60] [c039c430] bus_probe_device+0xb0/0xc4
[    4.575698] [c902bc80] [c0399b90] device_add+0x65c/0x8e8
[    4.580948] [c902bcd0] [c03f1f6c] __spi_add_device+0x80/0x158
[    4.586628] [c902bcf0] [c03f20ac] spi_add_device+0x68/0xac
[    4.592050] [c902bd00] [c03f2cf4] spi_register_controller+0x948/0xd1c
[    4.598419] [c902bd50] [c03f30f0] devm_spi_register_controller+0x28/0x94
[    4.605045] [c902bd70] [c03f5314] of_fsl_spi_probe+0x43c/0x5ac
[    4.610811] [c902bdc0] [c03a080c] platform_probe+0x60/0xc0
[    4.616233] [c902bdd0] [c039f190] really_probe+0x178/0x46c
[    4.621655] [c902bdf0] [c039e030] driver_probe_device+0xcc/0x12c
[    4.627593] [c902be10] [c039e368] __driver_attach+0x94/0x1c4
[    4.633187] [c902be30] [c039bc20] bus_for_each_dev+0x7c/0xbc
[    4.638781] [c902be60] [c039c73c] bus_add_driver+0x18c/0x238
[    4.644375] [c902be80] [c039f9f0] driver_register+0x9c/0x170
[    4.649969] [c902be90] [c1000ef0] do_one_initcall+0x80/0x170
[    4.655563] [c902bef0] [c10011f8] kernel_init_freeable+0x19c/0x244
[    4.661673] [c902bf20] [c0004b40] kernel_init+0x24/0x140
[    4.666923] [c902bf30] [c001122c] ret_from_kernel_thread+0x5c/0x64
[    4.673035] Instruction dump:
[    4.675961] 2c080000 41a2ffcc 814a0004 81040004 7d4a4051 4081ffbc 
7c031000 39200001
[    4.683791] b124000c 4d820020 4bff6570 39200000 <91230000> 39230004 
91230004 91230008
[    4.691804] ---[ end trace 0000000000000000 ]---

git bisect start
# good: [df0cc57e057f18e44dac8e6c18aba47ab53202f9] Linux 5.16
git bisect good df0cc57e057f18e44dac8e6c18aba47ab53202f9
# bad: [e783362eb54cd99b2cac8b3a9aeac942e6f6ac07] Linux 5.17-rc1
git bisect bad e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
# good: [fef8dfaea9d6c444b6c2174b3a2b0fca4d226c5e] Merge tag 
'regulator-v5.17' of 
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
git bisect good fef8dfaea9d6c444b6c2174b3a2b0fca4d226c5e
# good: [3ceff4ea07410763d5d4cccd60349bf7691e7e61] Merge tag 
'sound-5.17-rc1' of 
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect good 3ceff4ea07410763d5d4cccd60349bf7691e7e61
# bad: [79e06c4c4950be2abd8ca5d2428a8c915aa62c24] Merge tag 'for-linus' 
of git://git.kernel.org/pub/scm/virt/kvm/kvm
git bisect bad 79e06c4c4950be2abd8ca5d2428a8c915aa62c24
# bad: [a33f5c380c4bd3fa5278d690421b72052456d9fe] Merge tag 
'xfs-5.17-merge-3' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
git bisect bad a33f5c380c4bd3fa5278d690421b72052456d9fe
# bad: [0880603c8401505d237c8bfd29538a064e3aaf0f] counter: 
microchip-tcb-capture: Drop unused platform_set_drvdata()
git bisect bad 0880603c8401505d237c8bfd29538a064e3aaf0f
# bad: [1bb866dcb8cf5054de88f592fc0ec1f275ad9d63] Merge tag 
'iio-for-5.17a' of 
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into 
char-misc-next
git bisect bad 1bb866dcb8cf5054de88f592fc0ec1f275ad9d63
# bad: [c95cc0d95702523f8f361b802c9b7d4eeae07f5d] counter: 104-quad-8: 
Fix persistent enabled events bug
git bisect bad c95cc0d95702523f8f361b802c9b7d4eeae07f5d
# bad: [3953831982eb9c90506c4a2e8d7e6c3d840abf8a] Merge tag 
'lkdtm-v5.17-rc1' of 
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux into 
char-misc-next
git bisect bad 3953831982eb9c90506c4a2e8d7e6c3d840abf8a
# good: [01d3c42a08021617ad8ee79b0a9fed91d68e32b6] misc: at25: Get rid 
of intermediate storage for AT25 chip data
git bisect good 01d3c42a08021617ad8ee79b0a9fed91d68e32b6
# good: [33dc3e3e99e626ce51f462d883b05856c6c30b1d] w1: Misuse of 
get_user()/put_user() reported by sparse
git bisect good 33dc3e3e99e626ce51f462d883b05856c6c30b1d
# good: [2925fc1c102943a2496e13ef78d68acd5fd0dc99] misc: sram: Add 
compatible string for Tegra234 SYSRAM
git bisect good 2925fc1c102943a2496e13ef78d68acd5fd0dc99
# good: [bc93a22a19eb2b68a16ecf04cdf4b2ed65aaf398] lkdtm: Fix content of 
section containing lkdtm_rodata_do_nothing()
git bisect good bc93a22a19eb2b68a16ecf04cdf4b2ed65aaf398
# bad: [af40d16042d674442db8cf5fd654fabcd45fea44] Merge v5.15-rc5 into 
char-misc-next
git bisect bad af40d16042d674442db8cf5fd654fabcd45fea44
# good: [9a0a930fe2535a76ad70d3f43caeccf0d86a3009] binder: fix pointer 
cast warning
git bisect good 9a0a930fe2535a76ad70d3f43caeccf0d86a3009
# first bad commit: [af40d16042d674442db8cf5fd654fabcd45fea44] Merge 
v5.15-rc5 into char-misc-next

Thanks
Christophe

Powered by blists - more mailing lists