| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Jan 2022 04:14:04 +0800
From: kernel test robot <lkp@...el.com>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
robh+dt@...nel.org, gregkh@...uxfoundation.org
Cc: kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
ekangupt@....qualcomm.com, bkumar@....qualcomm.com,
linux-kernel@...r.kernel.org, srini@...nel.org,
bjorn.andersson@...aro.org, linux-arm-msm@...r.kernel.org,
Vamsi Krishna Gattupalli <quic_vgattupa@...cinc.com>
Subject: Re: [PATCH v3 11/12] misc: fastrpc: Add dma handle implementation
Hi Srinivas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on robh/for-next linux/master linus/master v5.17-rc1 next-20220125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/misc-fastrpc-Add-missing-DSP-FastRPC-features/20220126-215705
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 515a2f507491e7c3818e74ef4f4e088c1fecb190
config: arc-randconfig-r003-20220126 (https://download.01.org/0day-ci/archive/20220127/202201270412.QDMYUTEr-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/70d5973b9373ab26b6a1ed520ee07b71c7bdba63
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivas-Kandagatla/misc-fastrpc-Add-missing-DSP-FastRPC-features/20220126-215705
git checkout 70d5973b9373ab26b6a1ed520ee07b71c7bdba63
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/misc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/misc/fastrpc.c: In function 'fastrpc_req_mem_unmap_impl':
drivers/misc/fastrpc.c:1761:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1761 | args[0].ptr = (u64) &req_msg;
| ^
drivers/misc/fastrpc.c: In function 'fastrpc_req_mem_map':
drivers/misc/fastrpc.c:1811:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1811 | map->va = (void *) req.vaddrin;
| ^
drivers/misc/fastrpc.c:1816:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1816 | args[0].ptr = (u64) &req_msg;
| ^
drivers/misc/fastrpc.c:1822:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1822 | args[1].ptr = (u64) &pages;
| ^
drivers/misc/fastrpc.c:1825:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1825 | args[2].ptr = (u64) &pages;
| ^
drivers/misc/fastrpc.c:1828:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1828 | args[3].ptr = (u64) &rsp_msg;
| ^
drivers/misc/fastrpc.c: In function 'fastrpc_get_info_from_kernel.constprop':
>> drivers/misc/fastrpc.c:1552:1: warning: the frame size of 1076 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1552 | }
| ^
vim +1552 drivers/misc/fastrpc.c
a22465bb4904fac Jeya R 2022-01-26 1515
a22465bb4904fac Jeya R 2022-01-26 1516 static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap,
a22465bb4904fac Jeya R 2022-01-26 1517 struct fastrpc_user *fl)
a22465bb4904fac Jeya R 2022-01-26 1518 {
a22465bb4904fac Jeya R 2022-01-26 1519 struct fastrpc_channel_ctx *cctx = fl->cctx;
a22465bb4904fac Jeya R 2022-01-26 1520 uint32_t attribute_id = cap->attribute_id;
a22465bb4904fac Jeya R 2022-01-26 1521 uint32_t dsp_attributes[FASTRPC_MAX_DSP_ATTRIBUTES];
a22465bb4904fac Jeya R 2022-01-26 1522 unsigned long flags;
a22465bb4904fac Jeya R 2022-01-26 1523 uint32_t domain = cap->domain;
a22465bb4904fac Jeya R 2022-01-26 1524 int err;
a22465bb4904fac Jeya R 2022-01-26 1525
a22465bb4904fac Jeya R 2022-01-26 1526 spin_lock_irqsave(&cctx->lock, flags);
a22465bb4904fac Jeya R 2022-01-26 1527 /* check if we already have queried dsp for attributes */
a22465bb4904fac Jeya R 2022-01-26 1528 if (cctx->valid_attributes) {
a22465bb4904fac Jeya R 2022-01-26 1529 spin_unlock_irqrestore(&cctx->lock, flags);
a22465bb4904fac Jeya R 2022-01-26 1530 goto done;
a22465bb4904fac Jeya R 2022-01-26 1531 }
a22465bb4904fac Jeya R 2022-01-26 1532 spin_unlock_irqrestore(&cctx->lock, flags);
a22465bb4904fac Jeya R 2022-01-26 1533
a22465bb4904fac Jeya R 2022-01-26 1534 err = fastrpc_get_info_from_dsp(fl, &dsp_attributes[0], FASTRPC_MAX_DSP_ATTRIBUTES);
a22465bb4904fac Jeya R 2022-01-26 1535 if (err == DSP_UNSUPPORTED_API) {
a22465bb4904fac Jeya R 2022-01-26 1536 dev_info(&cctx->rpdev->dev,
a22465bb4904fac Jeya R 2022-01-26 1537 "Warning: DSP capabilities not supported on domain: %d\n", domain);
a22465bb4904fac Jeya R 2022-01-26 1538 return -EOPNOTSUPP;
a22465bb4904fac Jeya R 2022-01-26 1539 } else if (err) {
a22465bb4904fac Jeya R 2022-01-26 1540 dev_err(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err);
a22465bb4904fac Jeya R 2022-01-26 1541 return err;
a22465bb4904fac Jeya R 2022-01-26 1542 }
a22465bb4904fac Jeya R 2022-01-26 1543
a22465bb4904fac Jeya R 2022-01-26 1544 spin_lock_irqsave(&cctx->lock, flags);
a22465bb4904fac Jeya R 2022-01-26 1545 memcpy(cctx->dsp_attributes, dsp_attributes, sizeof(u32) * FASTRPC_MAX_DSP_ATTRIBUTES);
a22465bb4904fac Jeya R 2022-01-26 1546 cctx->valid_attributes = true;
a22465bb4904fac Jeya R 2022-01-26 1547 spin_unlock_irqrestore(&cctx->lock, flags);
a22465bb4904fac Jeya R 2022-01-26 1548 done:
a22465bb4904fac Jeya R 2022-01-26 1549 cap->capability = cctx->dsp_attributes[attribute_id];
a22465bb4904fac Jeya R 2022-01-26 1550
a22465bb4904fac Jeya R 2022-01-26 1551 return 0;
a22465bb4904fac Jeya R 2022-01-26 @1552 }
a22465bb4904fac Jeya R 2022-01-26 1553
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists