linux-kernel - Re: [PATCH v9 15/23] ima: Implement hierarchical processing of file accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d64ba364-e3fa-729a-2761-b386326ee276@linux.ibm.com>
Date:   Wed, 26 Jan 2022 17:05:05 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Christian Brauner <brauner@...nel.org>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:     linux-integrity@...r.kernel.org, zohar@...ux.ibm.com,
        serge@...lyn.com, christian.brauner@...ntu.com,
        containers@...ts.linux.dev, dmitry.kasatkin@...il.com,
        ebiederm@...ssion.com, krzysztof.struczynski@...wei.com,
        roberto.sassu@...wei.com, mpeters@...hat.com, lhinds@...hat.com,
        lsturman@...hat.com, puiterwi@...hat.com, jejb@...ux.ibm.com,
        jamjoom@...ibm.com, linux-kernel@...r.kernel.org,
        paul@...l-moore.com, rgb@...hat.com,
        linux-security-module@...r.kernel.org, jmorris@...ei.org
Subject: Re: [PATCH v9 15/23] ima: Implement hierarchical processing of file
 accesses


On 1/26/22 07:39, Christian Brauner wrote:
>
> That'll break compilation as youre checking:
>
> ns == &init_ima_ns below.
>
> security/integrity/ima/ima_main.c: In function ‘ima_post_read_file’:
> security/integrity/ima/ima_main.c:798:7: error: ‘ns’ undeclared (first use in this function); did you mean ‘insl’?
>    798 |   if (ns == &init_ima_ns &&
>        |       ^~
>        |       insl
> security/integrity/ima/ima_main.c:798:7: note: each undeclared identifier is reported only once for each function it appears in
>
> it's fixed later in the series but you might want to fix this up here as
> well.

Argh. Fixed.

>
> Fwiw, a good strategy is to:
>
> git rebase -i -x "make LOCALVERSION=-imans" v5.16-rc2

I did test it but maybe something distracted me....

while :; do make -j$(nproc) security kernel || break ; git rebase 
--continue || break; done