linux-kernel - Re: [PATCH net-next] net: drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADxym3ZJ14sXYVzoecQ97uqyuy_+N+mwjjh0x8Hyy_o7XTVCpw@mail.gmail.com>
Date:   Wed, 26 Jan 2022 11:38:29 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Neil Horman <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH net-next] net: drop_monitor: support drop reason

On Wed, Jan 26, 2022 at 11:38 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 24 Jan 2022 15:59:55 +0800 menglong8.dong@...il.com wrote:
> > @@ -606,6 +608,7 @@ static int net_dm_packet_report_in_port_put(struct sk_buff *msg, int ifindex,
> >  static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> >                                    size_t payload_len)
> >  {
> > +     enum skb_drop_reason reason = NET_DM_SKB_CB(skb)->reason;
> >       u64 pc = (u64)(uintptr_t) NET_DM_SKB_CB(skb)->pc;
>
> nit: maybe it's better to get a pointer to struct net_dm_skb_cb here
> instead of local var for each field?

Yeah, I think it's a good idea :/

>
> >       char buf[NET_DM_MAX_SYMBOL_LEN];
> >       struct nlattr *attr;
> > @@ -623,6 +626,9 @@ static int net_dm_packet_report_fill(struct sk_buff *msg, struct sk_buff *skb,
> >       if (nla_put_u64_64bit(msg, NET_DM_ATTR_PC, pc, NET_DM_ATTR_PAD))
> >               goto nla_put_failure;
> >
> > +     if (nla_put_u32(msg, NET_DM_ATTR_REASON, reason))
> > +             goto nla_put_failure;