linux-kernel - Re: [RFC V1 02/31] mm/mmap: Clarify protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfD1WFmlFYLkaJ/A@infradead.org>
Date:   Tue, 25 Jan 2022 23:16:40 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        hch@...radead.org, akpm@...ux-foundation.org
Subject: Re: [RFC V1 02/31] mm/mmap: Clarify protection_map[] indices

> +	[VM_NONE]				= __P000,
> +	[VM_READ]				= __P001,
> +	[VM_WRITE]				= __P010,
> +	[VM_READ|VM_WRITE]			= __P011,
> +	[VM_EXEC]				= __P100,
> +	[VM_EXEC|VM_READ]			= __P101,
> +	[VM_EXEC|VM_WRITE]			= __P110,
> +	[VM_EXEC|VM_READ|VM_WRITE]		= __P111,
> +	[VM_SHARED]				= __S000,
> +	[VM_SHARED|VM_READ]			= __S001,
> +	[VM_SHARED|VM_WRITE]			= __S010,
> +	[VM_SHARED|VM_READ|VM_WRITE]		= __S011,
> +	[VM_SHARED|VM_EXEC]			= __S100,
> +	[VM_SHARED|VM_READ|VM_EXEC]		= __S101,
> +	[VM_SHARED|VM_WRITE|VM_EXEC]		= __S110,
> +	[VM_SHARED|VM_READ|VM_WRITE|VM_EXEC]	= __S111

Please add whitespaces around the | operators.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>