lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Jan 2022 15:26:47 +0800 From: Miles Chen <miles.chen@...iatek.com> To: <wenst@...omium.org> CC: <chun-jie.chen@...iatek.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>, <mturquette@...libre.com>, <sboyd@...nel.org> Subject: Re: [PATCH 20/31] clk: mediatek: mtk: Clean up included headers > Some included headers aren't actually used anywhere, while other headers > with the declaration of functions and structures aren't directly > included. > > Get rid of the unused ones, and add the ones that should be included > directly. > > On the header side, replace headers that are included purely for data > structure definitions with forward declarations. This decreases the > amount of preprocessing and compilation effort required for each > inclusion. > > Signed-off-by: Chen-Yu Tsai <wenst@...omium.org> Reviewed-by: Miles Chen <miles.chen@...iatek.com> > --- > drivers/clk/mediatek/clk-mtk.c | 13 ++++++------- > drivers/clk/mediatek/clk-mtk.h | 12 ++++++------ > 2 files changed, 12 insertions(+), 13 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c > index cd76e1d80242..d2c50186cceb 100644 > --- a/drivers/clk/mediatek/clk-mtk.c > +++ b/drivers/clk/mediatek/clk-mtk.c > @@ -4,17 +4,16 @@ > * Author: James Liao <jamesjj.liao@...iatek.com> > */ > > -#include <linux/of.h> > -#include <linux/of_address.h> > +#include <linux/bitops.h> > +#include <linux/clk-provider.h> > #include <linux/err.h> > #include <linux/io.h> > -#include <linux/slab.h> > -#include <linux/delay.h> > -#include <linux/clkdev.h> > -#include <linux/module.h> > #include <linux/mfd/syscon.h> > -#include <linux/device.h> > +#include <linux/module.h> > +#include <linux/of.h> > #include <linux/of_device.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > > #include "clk-mtk.h" > #include "clk-gate.h" > diff --git a/drivers/clk/mediatek/clk-mtk.h b/drivers/clk/mediatek/clk-mtk.h > index 4fa658f5d934..7f902581a115 100644 > --- a/drivers/clk/mediatek/clk-mtk.h > +++ b/drivers/clk/mediatek/clk-mtk.h > @@ -7,19 +7,19 @@ > #ifndef __DRV_CLK_MTK_H > #define __DRV_CLK_MTK_H > > -#include <linux/regmap.h> > -#include <linux/bitops.h> > #include <linux/clk-provider.h> > -#include <linux/platform_device.h> > - > -struct clk; > -struct clk_onecell_data; > +#include <linux/io.h> > +#include <linux/kernel.h> > +#include <linux/spinlock.h> > +#include <linux/types.h> > > #define MAX_MUX_GATE_BIT 31 > #define INVALID_MUX_GATE_BIT (MAX_MUX_GATE_BIT + 1) > > #define MHZ (1000 * 1000) > > +struct platform_device; > + > struct mtk_fixed_clk { > int id; > const char *name; > -- > 2.35.0.rc0.227.g00780c9af4-goog
Powered by blists - more mailing lists