linux-kernel - Re: [PATCH] mm/highmem: remove unnecessary done label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b1bf433-067b-ebfb-4603-2e31e1990f77@redhat.com>
Date:   Wed, 26 Jan 2022 11:21:27 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/highmem: remove unnecessary done label

On 26.01.22 10:25, Miaohe Lin wrote:
> Remove unnecessary done label to simplify the code.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  mm/highmem.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 762679050c9a..0cc0c4da7ed9 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -736,11 +736,11 @@ void *page_address(const struct page *page)
>  		list_for_each_entry(pam, &pas->lh, list) {
>  			if (pam->page == page) {
>  				ret = pam->virtual;
> -				goto done;
> +				break;
>  			}
>  		}
>  	}
> -done:
> +
>  	spin_unlock_irqrestore(&pas->lock, flags);
>  	return ret;
>  }
> @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual)
>  		list_for_each_entry(pam, &pas->lh, list) {
>  			if (pam->page == page) {
>  				list_del(&pam->list);
> -				spin_unlock_irqrestore(&pas->lock, flags);
> -				goto done;
> +				break;
>  			}
>  		}
>  		spin_unlock_irqrestore(&pas->lock, flags);
>  	}
> -done:
> +
>  	return;
>  }
>  

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb