linux-kernel - Re: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ee4u7nxl.wl-maz@kernel.org>
Date:   Wed, 26 Jan 2022 11:10:14 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        kernel-team@...roid.com, Jay Chen <jkchen@...ux.alibaba.com>
Subject: Re: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe

On Wed, 26 Jan 2022 09:57:26 +0000,
Lorenzo Pieralisi <lorenzo.pieralisi@....com> wrote:
> 
> >  static void __init its_acpi_probe(void)
> >  {
> >  	acpi_table_parse_srat_its();
> > -	acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > -			      gic_acpi_parse_madt_its, 0);
> > +	if (acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > +				  its_acpi_reset, 0) > 0)
> > +		acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > +				      gic_acpi_parse_madt_its, 0);
> 
> Maybe it is worth adding a comment here as you did for DT if you
> can before merging it - to clarify the first acpi_table_parse_madt()
> call logic.

Sure, I'll add that.

> 
> Other than that:
> 
> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.