linux-kernel - Re: [RESEND][PATCH] Documentation: added order requirement for ima

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1bfe53abaf24feacb676ce940edcb8899924ffc.camel@linux.ibm.com>
Date:   Wed, 26 Jan 2022 07:47:51 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     "Guozihua (Scott)" <guozihua@...wei.com>,
        Jonathan Corbet <corbet@....net>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        roberto.sassu@...wei.com, wangweiyang2@...wei.com,
        xiujianfeng@...wei.com, linux-integrity@...r.kernel.org
Subject: Re: [RESEND][PATCH] Documentation: added order requirement for
 ima_hash=

On Wed, 2022-01-26 at 15:41 +0800, Guozihua (Scott) wrote:
> 
> 
> The main issue lies in ima_template_desc_current called by hash_setup, 
> which does not just read ima_template global variable, but also tries to 
> set it if that hasn't been done already. Causing ima_template_setup to quit.

Right, which calls ima_init_template_list().  So part of the solution
could be to conditionally call ima_init_template_list()
in ima_template_setup().

-       if (ima_template)
-               return 1;
-
-       ima_init_template_list();
+       if (!ima_template
+               ima_init_template_list();

Roberto, what do you think?

thanks,

Mimi