linux-kernel - Re: [PATCH v2] blk-mq: fix missing blk_account_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164320409207.123597.5205274330613779469.b4-ty@kernel.dk>
Date:   Wed, 26 Jan 2022 06:34:52 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH v2] blk-mq: fix missing blk_account_io_done() in error path

On Wed, 26 Jan 2022 09:21:32 +0800, Yu Kuai wrote:
> If blk_mq_request_issue_directly() failed from
> blk_insert_cloned_request(), the request will be accounted start.
> Currently, blk_insert_cloned_request() is only called by dm, and such
> request won't be accounted done by dm.
> 
> In normal path, io will be accounted start from blk_mq_bio_to_request(),
> when the request is allocated, and such io will be accounted done from
> __blk_mq_end_request_acct() whether it succeeded or failed. Thus add
> blk_account_io_done() to fix the problem.
> 
> [...]

Applied, thanks!

[1/1] blk-mq: fix missing blk_account_io_done() in error path
      commit: 592ee1197f78b30bd60c87db9b6c8c045c8d8314

Best regards,
-- 
Jens Axboe