linux-kernel - Re: [PATCH v3] tty: Partially revert the removal of the Cyclades public API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfFRlbKw4cV+ISfk@kroah.com>
Date:   Wed, 26 Jan 2022 14:50:13 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Maciej W. Rozycki" <macro@...ecosm.com>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v3] tty: Partially revert the removal of the Cyclades
 public API

On Wed, Jan 26, 2022 at 09:22:54AM +0000, Maciej W. Rozycki wrote:
> Fix a user API regression introduced with commit f76edd8f7ce0 ("tty: 
> cyclades, remove this orphan"), which removed a part of the API and 
> caused compilation errors for user programs using said part, such as 
> GCC 9 in its libsanitizer component[1]:
> 
> .../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:160:10: fatal error: linux/cyclades.h: No such file or directory
>   160 | #include <linux/cyclades.h>
>       |          ^~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [Makefile:664: sanitizer_platform_limits_posix.lo] Error 1
> 
> As the absolute minimum required bring `struct cyclades_monitor' and 
> ioctl numbers back then so as to make the library build again.  Add a 
> preprocessor warning as to the obsolescence of the features provided.
> 
> References:
> 
> [1] GCC PR sanitizer/100379, "cyclades.h is removed from linux kernel 
>     header files", <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100379>
> 
> Signed-off-by: Maciej W. Rozycki <macro@...ecosm.com>
> Fixes: f76edd8f7ce0 ("tty: cyclades, remove this orphan")
> Cc: stable@...r.kernel.org # v5.13+
> ---
> Changes from v2:
> 
> - Add #warning directives.

Thanks, that looks good, now queued up.

greg k-h