linux-kernel - Re: [PATCH v2] net: ena: Do not waste napi skb cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pj41zlilu61q85.fsf@u570694869fb251.ant.amazon.com>
Date:   Wed, 26 Jan 2022 17:16:35 +0200
From:   Shay Agroskin <shayagr@...zon.com>
To:     Hyeonggon Yoo <42.hyeyoo@...il.com>
CC:     <jwiedmann.dev@...il.com>, Arthur Kiyanovski <akiyano@...zon.com>,
        "David Arinzon" <darinzon@...zon.com>,
        Noam Dagan <ndagan@...zon.com>,
        "Saeed Bishara" <saeedb@...zon.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Sameeh Jubran" <sameehj@...zon.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "Lorenzo Bianconi" <lorenzo@...nel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache


Hyeonggon Yoo <42.hyeyoo@...il.com> writes:

> CAUTION: This email originated from outside of the 
> organization. Do not click links or open attachments unless you 
> can confirm the sender and know the content is safe.
>
>
>
> By profiling, discovered that ena device driver allocates skb by
> build_skb() and frees by napi_skb_cache_put(). Because the 
> driver
> does not use napi skb cache in allocation path, napi skb cache 
> is
> periodically filled and flushed. This is waste of napi skb 
> cache.
>
> As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> and napi_alloc_skb() when allocating skb.
>
> This patch was tested on aws a1.metal instance.
>
> [ jwiedmann.dev@...il.com: Use napi_alloc_skb() instead of
>   netdev_alloc_skb_ip_align() to keep things consistent. ]
>
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@...il.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>

Thank you for this work

Acked-by: Shay Agroskin <shayagr@...zon.com>