linux-kernel - Re: [PATCH v2] iio: dps310: Add ACPI HID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vetc62kz7VtEgWR2Jn_UsmYtzR1WM0n4pxycfKCN3h3+Q@mail.gmail.com>
Date:   Thu, 27 Jan 2022 18:22:23 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Eddie James <eajames@...ux.ibm.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] iio: dps310: Add ACPI HID table

On Thu, Jan 27, 2022 at 4:38 PM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
>
> x86 boards may use ACPI HID "IFX3100" for dps310 device.

the dps310

> Vendor told us feel free to add the ID and contact
> "Saumitra.Chafekar@...ineon.com" for any further question.

questions

> So add an ACPI match table for that accordingly.

I have checked the official PNP registry and may confirm IFX is for
Infineon, since they are aware
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Thanks for all your efforts, appreciate it!

> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v2:
>  - Drop ACPI_PTR().
>  - Add info from vendor.
>
>  drivers/iio/pressure/dps310.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
> index 0730380ceb692..7e6fcb32212a2 100644
> --- a/drivers/iio/pressure/dps310.c
> +++ b/drivers/iio/pressure/dps310.c
> @@ -812,9 +812,17 @@ static const struct i2c_device_id dps310_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, dps310_id);
>
> +static const struct acpi_device_id dps310_acpi_match[] = {
> +       { "IFX3100" },
> +       { },
> +};

> +

This is redundant, I hope Jonathan may remove it when applying.

> +MODULE_DEVICE_TABLE(acpi, dps310_acpi_match);
> +
>  static struct i2c_driver dps310_driver = {
>         .driver = {
>                 .name = DPS310_DEV_NAME,
> +               .acpi_match_table = dps310_acpi_match,
>         },
>         .probe = dps310_probe,
>         .id_table = dps310_id,
> --
> 2.33.1
>


-- 
With Best Regards,
Andy Shevchenko