linux-kernel - Re: [PATCH V4] panic: Move panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 13:47:34 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Baoquan He <bhe@...hat.com>, akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, pmladek@...e.com, anton@...msg.org,
        ccross@...roid.com, dyoung@...hat.com, feng.tang@...el.com,
        john.ogness@...utronix.de, keescook@...omium.org,
        kernel@...ccoli.net, kexec@...ts.infradead.org,
        rostedt@...dmis.org, senozhatsky@...omium.org, tony.luck@...el.com,
        vgoyal@...hat.com
Subject: Re: [PATCH V4] panic: Move panic_print before kmsg dumpers

On 26/01/2022 02:22, Baoquan He wrote:
> [...]
>>  	if (!_crash_kexec_post_notifiers) {
>> +		if (kexec_crash_loaded())
>> +			panic_print_sys_info(false);
>> +
> 
> Please reconsider this change. As I said in another thread, it's not
> suggested when adding any action before kdump switching and the action
> doesn't benefit kdump switching.
> 
> We don't oppose execute handling before kdump switching as long as
> it's executed conditionally. For those conditional extra handling and
> the followoing crash dumping's stability, it's not under kdump's care.
> 

Hi Baoquan, thanks for your review - I understand your concern, so let's
reconsider the change, as you suggest. The only thing is that the
specific bit that concerns you is not really a code added by the hereby
proposed patch, but it was in another patch I submitted, that reached
linux-next.

So, Andrew : can I ask you to please remove the following patch from
linux-next?

"panic: allow printing extra panic information on kdump"
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=56439cb78293

(I'll also send this request in the original thread of the patch, for
completeness).

Baoquan: once it's removed from linux-next, I'll rework this proposed
patch and send a V5, hopefully a version that you consider more safe =)
Cheers,


Guilherme