linux-kernel - RE: [PATCH v2 2/6] x86/cpu: Merge Intel and AMD ppin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 16:52:43 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Smita Koralahalli Channabasappa 
        <smita.koralahallichannabasappa@....com>,
        Wei Huang <wei.huang2@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH v2 2/6] x86/cpu: Merge Intel and AMD ppin_init() functions

>> +	[X86_VENDOR_AMD] = {
>> +		.feature = X86_FEATURE_AMD_PPIN,
>> +		.msr_ppin_ctl = MSR_AMD_PPIN_CTL,
>> +		.msr_ppin = MSR_AMD_PPIN
>		^^^^^^^^^
>
> You forgot to rebuild after removing that guy here in the struct
> definition. I'll fix it up now so that I can continue going through them
> but pls fix in the next submission so that all patches build separately.

Oops. Sorry. Yes. I will move those initializations out of this patch
and into the later patch when the .msr_ppin field is added.

I'll wait on posting v3 until you finish with the rest of v2.

Thanks

-Tony