linux-kernel - Re: [PATCH -next] blk-mq: Fix wrong wakeup batch configuration which will cause hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164330383030.210260.14632628670635722739.b4-ty@kernel.dk>
Date:   Thu, 27 Jan 2022 10:17:10 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Laibin Qiu <qiulaibin@...wei.com>,
        andriy.shevchenko@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        alex_y_xu@...oo.ca
Subject: Re: [PATCH -next] blk-mq: Fix wrong wakeup batch configuration which will cause hang

On Thu, 27 Jan 2022 18:00:47 +0800, Laibin Qiu wrote:
> Commit 180dccb0dba4f ("blk-mq: fix tag_get wait task can't be
> awakened") will recalculating wake_batch when inc or dec active_queues
> to avoid wake_batch is > hctx_max_depth. At the same time, in order to
> not affect performance as much as possible, the minimum wakeup batch is
> set to 4. But when the QD is small (such as QD=1), if inc or dec
> active_queues will increase wakeup batch, which will lead to hang.
> 
> [...]

Applied, thanks!

[1/1] blk-mq: Fix wrong wakeup batch configuration which will cause hang
      commit: 10825410b956dc1ed8c5fbc8bbedaffdadde7f20

Best regards,
-- 
Jens Axboe