linux-kernel - Re: [PATCH] usb: usb251xb: add boost-up property support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220127175358.GA3171@tom-desktop>
Date:   Thu, 27 Jan 2022 18:53:58 +0100
From:   Tommaso Merciai <tomm.merciai@...il.com>
To:     Richard Leitner <richard.leitner@...ux.dev>
Cc:     Richard Leitner - SKIDATA <Richard.Leitner@...data.com>,
        "linuxfancy@...glegroups.com" <linuxfancy@...glegroups.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: usb251xb: add boost-up property support

On Wed, Jan 26, 2022 at 08:08:48AM +0100, Richard Leitner wrote:
> On Tue, Jan 25, 2022 at 10:42:45PM +0100, Tommaso Merciai wrote:
> > On Mon, Jan 24, 2022 at 07:03:57AM +0000, Richard Leitner - SKIDATA wrote:
> > > On Sat, Jan 22, 2022 at 12:26:12AM +0100, Tommaso Merciai wrote:
> > > >  
> > > > +	if (!of_property_read_u8(np, "boost-up", &property_u8)){
> > > > +		hub->boost_up = property_u8;
> > > 
> > > IMHO we don't need the property_u8 var here as you could pass
> > > &hub->boost_up directly to of_property_read_u8() ?
> > 
> > Hi Richard,
> > Thanks for your reply. You mean like:
> > 
> > if (!of_property_read_u8(np, "boost-up", &hub->boost_up))
> 
> exactly.

Thanks Richard,
I'll send v2.

Thanks,
Tommaso

> 
> > 
> > Let me know. I'll fix that in v2.
> > 
> 
> great!
> 
> thanks & regards;rl