linux-kernel - Re: [PATCH] selftests: futex: Use variable MAKE instead of make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65054310-e925-4072-7df2-e1550d8a9a4f@collabora.com>
Date:   Thu, 27 Jan 2022 15:09:44 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc:     kernel@...labora.com, linux-kernel@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Darren Hart <dvhart@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
Subject: Re: [PATCH] selftests: futex: Use variable MAKE instead of make

Hi Usama,

Às 14:44 de 27/01/22, Muhammad Usama Anjum escreveu:
> Recursive make commands should always use the variable MAKE, not the
> explicit command name ‘make’. This has benefits and removes the
> following warning when multiple jobs are used for the build:
> 
> make[2]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
> 
> Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

Thanks for the patch!

Reviewed-by: André Almeida <andrealmeid@...labora.com>

> ---
>  tools/testing/selftests/futex/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
> index 12631f0076a10..11e157d7533b8 100644
> --- a/tools/testing/selftests/futex/Makefile
> +++ b/tools/testing/selftests/futex/Makefile
> @@ -11,7 +11,7 @@ all:
>  	@for DIR in $(SUBDIRS); do		\
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
> -		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> +		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>  		if [ -e $$DIR/$(TEST_PROGS) ]; then \
>  			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>  		fi \
> @@ -32,6 +32,6 @@ override define CLEAN
>  	@for DIR in $(SUBDIRS); do		\
>  		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>  		mkdir $$BUILD_TARGET  -p;	\
> -		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
> +		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>  	done
>  endef