linux-kernel - Re: [PATCH] spi: bcm-qspi: check for valid cs before applying chip select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01d73e56-346b-a175-6113-db98be6b0a53@gmail.com>
Date:   Thu, 27 Jan 2022 10:59:10 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kamal Dasu <kdasu.kdev@...il.com>, broonie@...nel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH] spi: bcm-qspi: check for valid cs before applying chip
 select



On 1/27/2022 10:53 AM, Kamal Dasu wrote:
> Apply only valid chip select value. This change fixes case where chip
> select is set to initial value of '-1' during probe and  PM supend and
> subsequent resume can try to use the value with undefined behaviour.
> Also in case where gpio based chip select, the check in
> bcm_qspi_chip_select() shall prevent undefined behaviour on resume.
> 
> Fixes: fa236a7ef240 ("spi: bcm-qspi: Add Broadcom MSPI driver")
> Signed-off-by: Kamal Dasu <kdasu.kdev@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian