linux-kernel - Re: [PATCH] drm/amdgpu: Wrong order for config and counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PUmz=G2LbCQEF9==K4GLRNbRWAMp+4V3N_ZpgV1DCB3A@mail.gmail.com>
Date:   Thu, 27 Jan 2022 15:16:50 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Qu Huang <jinsdb@....com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters

Applied.  Thanks!

Alex

On Wed, Jan 26, 2022 at 4:48 AM <jinsdb@....com> wrote:
>
> From: huangqu <jinsdb@....com>
>
> Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
>
> Signed-off-by: huangqu <jinsdb@....com>
> ---
>  drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> index 43c5e3ec9..f4dfca013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> @@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
>
>  #define DEFERRED_ARM_MASK      (1 << 31)
>  static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> -                                   int counter_idx, uint64_t config,
> +                                   uint64_t config, int counter_idx,
>                                     bool is_deferred)
>  {
>
> @@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
>  }
>
>  static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
> -                                   int counter_idx,
> -                                   uint64_t config)
> +                                   uint64_t config,
> +                                   int counter_idx)
>  {
>         return  (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
>                         (adev->df_perfmon_config_assign_mask[counter_idx]
> --
> 2.31.1
>