linux-kernel - Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfMVRasTSQrr1ob+@shikoro>
Date:   Thu, 27 Jan 2022 22:57:25 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     u.kleine-koenig@...gutronix.de, andy.shevchenko@...il.com,
        christian.koenig@....com, digetx@...il.com,
        gregkh@...uxfoundation.org, jonathanh@...dia.com,
        ldewangan@...dia.com, lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, rafael@...nel.org,
        sumit.semwal@...aro.org, thierry.reding@...il.com
Subject: Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of
 of_*()

Hi,

> +	irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
> +					   "smbus_alert");

I think we should include "linux/property.h" for it. Interesting, the of
header was never included.

> -		irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> +		irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
> +					    "smbus_alert");

Here we should replace of_irq.h with property.h.

Rest looks good!

Happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)