linux-kernel - Re: [PATCH 4/5] selftests: openat2: Add missing dependency in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5d165af-6f89-f94b-f6da-d0b231c72929@linuxfoundation.org>
Date:   Thu, 27 Jan 2022 16:12:40 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Cristian Marussi <cristian.marussi@....com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     shuah@...nel.org, Aleksa Sarai <cyphar@...har.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 4/5] selftests: openat2: Add missing dependency in
 Makefile

On 1/26/22 3:27 AM, Cristian Marussi wrote:
> Add a dependency on header helpers.h to the main target; while at that add
> to helpers.h also a missing include for bool types.
> 
> Cc: Aleksa Sarai <cyphar@...har.com>
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
>   tools/testing/selftests/openat2/Makefile  | 2 +-
>   tools/testing/selftests/openat2/helpers.h | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile
> index 4b93b1417b86..843ba56d8e49 100644
> --- a/tools/testing/selftests/openat2/Makefile
> +++ b/tools/testing/selftests/openat2/Makefile
> @@ -5,4 +5,4 @@ TEST_GEN_PROGS := openat2_test resolve_test rename_attack_test
>   
>   include ../lib.mk
>   
> -$(TEST_GEN_PROGS): helpers.c
> +$(TEST_GEN_PROGS): helpers.c helpers.h
> diff --git a/tools/testing/selftests/openat2/helpers.h b/tools/testing/selftests/openat2/helpers.h
> index ad5d0ba5b6ce..7056340b9339 100644
> --- a/tools/testing/selftests/openat2/helpers.h
> +++ b/tools/testing/selftests/openat2/helpers.h
> @@ -9,6 +9,7 @@
>   
>   #define _GNU_SOURCE
>   #include <stdint.h>
> +#include <stdbool.h>
>   #include <errno.h>
>   #include <linux/types.h>
>   #include "../kselftest.h"
> 

Thanks for the patch. Will apply for linux-kselftest fixes branch for rc3

thanks,
-- Shuah