[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b7ce8b9e-e11e-fe7e-bf20-41cee9ee933b@norik.com>
Date: Thu, 27 Jan 2022 07:29:31 +0100
From: Andrej Picej <andrej.picej@...ik.com>
To: Shawn Guo <shawnguo@...nel.org>
Cc: robh+dt@...nel.org, s.hauer@...gutronix.de,
devicetree@...r.kernel.org, festevam@...il.com,
kernel@...gutronix.de, linux-kernel@...r.kernel.org,
y.bas@...tec.com
Subject: Re: [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded
MFD-subdevices correctly
On 26. 01. 22 10:27, Shawn Guo wrote:
> On Thu, Dec 16, 2021 at 12:55:29PM +0100, Andrej Picej wrote:
>> From: Yunus Bas <y.bas@...tec.de>
>>
>> The proper way to handle partly used MFD devices are to describe all MFD
>> subdevices in the devicetree and disable the not used ones. This
>> suppresses any warnings that may arise as a result.
>>
>> Signed-off-by: Yunus Bas <y.bas@...tec.de>
>> Signed-off-by: Andrej Picej <andrej.picej@...ik.com>
>
> Use subject prefix like
>
> ARM: dts: imx6qdl-phytec: ...
>
> Shawn
Will send a v2 with this change.
Thanks.
Andrej
>
>> ---
>> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 5 +++++
>> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 10 ++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> index 2ec154756bbc..3590f439adf5 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
>> @@ -213,6 +213,11 @@ pmic_rtc: rtc {
>> da9063_wdog: wdt {
>> compatible = "dlg,da9063-watchdog";
>> };
>> +
>> + onkey {
>> + compatible = "dlg,da9063-onkey";
>> + status = "disabled";
>> + };
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> index 94b254bfd054..28a805384668 100644
>> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
>> @@ -116,6 +116,16 @@ watchdog {
>> dlg,use-sw-pm;
>> };
>>
>> + thermal {
>> + compatible = "dlg,da9062-thermal";
>> + status = "disabled";
>> + };
>> +
>> + gpio {
>> + compatible = "dlg,da9062-gpio";
>> + status = "disabled";
>> + };
>> +
>> regulators {
>> vdd_arm: buck1 {
>> regulator-name = "vdd_arm";
>> --
>> 2.25.1
>>
Powered by blists - more mailing lists