linux-kernel - Re: [v5 PATCH] block: introduce block_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfJrsid0OJQykXYz@infradead.org>
Date:   Thu, 27 Jan 2022 01:53:54 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     Yang Shi <shy828301@...il.com>
Cc:     axboe@...nel.dk, hch@...radead.org, rostedt@...dmis.org,
        xiyou.wangcong@...il.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v5 PATCH] block: introduce block_rq_error tracepoint

On Wed, Jan 26, 2022 at 10:51:53AM -0800, Yang Shi wrote:
> +		__entry->dev	   = rq->q->disk ? disk_devt(rq->q->disk) : 0;
> +		__assign_str(name,   rq->q->disk ? rq->q->disk->disk_name : "?");

None f the other tracepoints has the disk name, why does this one need
it?  And if you add it please avoid the overly long line.

> +		__entry->sector    = blk_rq_pos(rq);
> +		__entry->nr_sector = nr_bytes >> 9;
> +		__entry->error     = blk_status_to_errno(error);

This still converts the block status to an errno.