linux-kernel - Re: [PATCH] drivers: dio: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 11:08:56 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Aleksa Vučković <aleksav013@...il.com>
Cc:     salah.triki@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: dio: Fixed coding style issues

On Thu, Jan 27, 2022 at 11:04:14AM +0100, Aleksa Vučković wrote:
> Hey,
> 
> I made a really simple patch fixing coding style errors.
> Could you please review it, and tell me how to prevent errors like this:
> 
> > - Your patch did many different things all at once, making it
> > difficult to review.
> 
> from happening in the future.
> 
> Should i split changes into 2 patches? One for upper half and one for
> lower half of the file I changed?

One patch per type of logical change is recommended, the location in the
file does not matter.

> Many lines have multiple errors, so if I fix one error, I also need to
> fix the other one.

That's not a problem, and is not why your previous patches were
rejected.  Your previous patches were rejected as in your attempts to
fix coding style issues you added new ones.

> So I can not just have patch fixing one thing at the
> time. Should I try to fix error in this manner:
> [PATCH 1/3] fix lines that have ONLY spaces to tabs error
> [PATCH 2/3] fix lines that have ONLY braces error
> [PATCH 3/3] fix lines that have spaces to tabs error AND braces error
> or should I have a different approach?

Look at the examples on the staging mailing list for how to do this
well.  There are thousands of examples of "do only one type of change
per patch" out there.  To ignore the work others have done is odd.

> Sorry for bothering, this is my first time submitting patches.

Please start out by working in the drivers/staging/ part of the kernel
when learning how to do development, as that is explicitly what that
part of the kernel is for, and it keeps other maintainers from being
bothered by basic functionality and procedural issues like this.

thanks,

greg k-h