linux-kernel - Re: [PATCH 01/16] scsi: libsas: Use enum for response frame DATAPRES field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfJxzi1udZQhAYKW@infradead.org>
Date:   Thu, 27 Jan 2022 02:19:58 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     John Garry <john.garry@...wei.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        artur.paszkiewicz@...el.com, jinpu.wang@...ud.ionos.com,
        chenxiang66@...ilicon.com, Ajish.Koshy@...rochip.com,
        yanaijie@...wei.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        linuxarm@...wei.com, liuqi115@...wei.com, Viswas.G@...rochip.com,
        damien.lemoal@...nsource.wdc.com
Subject: Re: [PATCH 01/16] scsi: libsas: Use enum for response frame DATAPRES
 field

On Tue, Jan 25, 2022 at 07:32:37PM +0800, John Garry wrote:
> -	if (iu->datapres == 0)
> +	if (iu->datapres == NO_DATA)
>  		tstat->stat = iu->status;
> -	else if (iu->datapres == 1)
> +	else if (iu->datapres == RESPONSE_DATA)
>  		tstat->stat = iu->resp_data[3];
> -	else if (iu->datapres == 2) {
> +	else if (iu->datapres == SENSE_DATA) {

Maybe use a switch here to make it more obvious?