linux-kernel - Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <495878a237748e3652619e692706b9352969f435.camel@redhat.com>
Date:   Thu, 27 Jan 2022 12:22:10 +0200
From:   Maxim Levitsky <mlevitsk@...hat.com>
To:     Mike Lothian <mike@...eburn.co.uk>
Cc:     dwmw@...zon.co.uk, iommu@...ts.linux-foundation.org,
        joro@...tes.org, linux-kernel@...r.kernel.org,
        suravee.suthikulpanit@....com, tglx@...utronix.de, will@...nel.org
Subject: Re: [PATCH 0/5] iommu/amd: fixes for suspend/resume

On Thu, 2022-01-27 at 00:39 +0000, Mike Lothian wrote:
> On Wed, 26 Jan 2022 at 10:12, Maxim Levitsky <mlevitsk@...hat.com> wrote:
> > Great, your system does seem to support GA log
> > (but a patch to check if, other that assume blindly that it is supported is
> > something that should be done).
> > 
> > So could you bump the LOOP_TIMEOUT like by 10x or so and see if the problem goes away?
> > 
> > (that code should be rewritten to time based wait and not just blindly loop like that,
> > I also can prepare a patch for that as well).
> > 
> > Best regards,
> >         Maxim Levitsky
> > 
> 
> Hi
> 
> I've done quite a few restarts with the LOOP_TIMEOUT increased and
> I've not seen the issue since

Great, so the problem is solved I guess. 
Thanks for the help!


I'll send a patch for this in few days to replace this and other similiar timeouts
with a proper udelay() wait.

Best regards,
	Maxim Levitsky

> 
> Cheers
> 
> Mike
>