linux-kernel - Re: [PATCH] crypto: atmel: add support for AES and SHA IPs available on lan966x SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 11:29:11 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        nicolas.ferre@...rochip.com, ludovic.desroches@...rochip.com,
        tudor.ambarus@...rochip.com, UNGLinuxDriver@...rochip.com,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: atmel: add support for AES and SHA IPs available
 on lan966x SoC

On 27/01/2022 13:34:08+0530, Kavyasree Kotagiri wrote:
> This patch adds support for hardware version of AES and SHA IPs
> available on lan966x SoC.
> 
> Tested-by: Vradha Panchal <vradha.panchal@...rochip.com>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> ---
>  drivers/crypto/atmel-aes.c | 2 ++
>  drivers/crypto/atmel-sha.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index fe0558403191..358f1092d890 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -2509,6 +2509,8 @@ static void atmel_aes_get_cap(struct atmel_aes_dev *dd)
>  
>  	/* keep only major version number */
>  	switch (dd->hw_version & 0xff0) {
> +	case 0x700:
> +		fallthrough;

I don't think fallthrough is needed in that case.
>  	case 0x500:
>  		dd->caps.has_dualbuff = 1;
>  		dd->caps.has_cfb64 = 1;
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 1b13f601fd95..6c7bb91c8cce 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -2508,6 +2508,8 @@ static void atmel_sha_get_cap(struct atmel_sha_dev *dd)
>  
>  	/* keep only major version number */
>  	switch (dd->hw_version & 0xff0) {
> +	case 0x700:
> +		fallthrough;
>  	case 0x510:
>  		dd->caps.has_dma = 1;
>  		dd->caps.has_dualbuff = 1;
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com