linux-kernel - Re: [PATCH V4 2/6] bindings: usb: dwc3: Update dwc3 properties for EUD connector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ecf4224-4a8c-6508-a3de-df1c3119bb28@quicinc.com>
Date:   Thu, 27 Jan 2022 16:28:47 +0530
From:   Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <pure.logic@...us-software.ie>,
        <greg@...ah.com>, <robh@...nel.org>,
        <linux-kernel@...r.kernel.org>, <quic_tsoni@...cinc.com>,
        <quic_psodagud@...cinc.com>, <quic_satyap@...cinc.com>,
        <quic_pheragu@...cinc.com>, <quic_rjendra@...cinc.com>,
        <quic_sibis@...cinc.com>, <quic_saipraka@...cinc.com>
Subject: Re: [PATCH V4 2/6] bindings: usb: dwc3: Update dwc3 properties for
 EUD connector


On 1/26/2022 9:51 AM, Bjorn Andersson wrote:
> On Fri 21 Jan 07:53 CST 2022, Souradeep Chowdhury wrote:
>
>> Add the ports property for dwc3 node. This port can be used
>> by the Embedded USB Debugger for role switching the controller
>> from device to host mode and vice versa.
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> ---
>>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> index d29ffcd..ccb1236 100644
>> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
>> @@ -332,6 +332,16 @@ properties:
>>       items:
>>         enum: [1, 4, 8, 16, 32, 64, 128, 256]
>>   
>> +  ports:
>> +    $ref: /schemas/graph.yaml#/properties/ports
>> +    description:
>> +      This port is to be attached to the endpoint of the Embedded USB Debugger.
> More generally this is used together with the already documented
> usb-role-switch property to connect the dwc3 to the Type-C connector.
>
> Which makes me feel that we don't actually need ports/port, but could do
> with just port? Perhaps I'm missing some usecase?
>
>
> I'm somewhat confused to why this isn't already documented...

Ack. Will document this as a port.

>
> Regards,
> Bjorn
>
>> +
>> +    properties:
>> +      port@0:
>> +        $ref: /schemas/graph.yaml#/properties/port
>> +        description: Connector endpoint of Embedded USB debugger.
>> +
>>   unevaluatedProperties: false
>>   
>>   required:
>> -- 
>> 2.7.4
>>