linux-kernel - Re: [PATCH] pinctrl: microchip-sgpio: Fix support for regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ebaf35c71a15326a7bd9be2676846050ccc8eb4.camel@microchip.com>
Date:   Thu, 27 Jan 2022 12:42:58 +0000
From:   <Steen.Hegelund@...rochip.com>
To:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Horatiu.Vultur@...rochip.com>
CC:     <Lars.Povlsen@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
        <linus.walleij@...aro.org>, <colin.foster@...advantage.com>
Subject: Re: [PATCH] pinctrl: microchip-sgpio: Fix support for regmap

Good catch Horatiu.

BR
Steen

Acked-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

On Tue, 2022-01-25 at 17:12 +0100, Horatiu Vultur wrote:
> Initially the driver accessed the registers using u32 __iomem but then
> in the blamed commit it changed it to use regmap. The problem is that now
> the offset of the registers is not calculated anymore at word offset but
> at byte offset. Therefore make sure to multiply the offset with word size.
> 
> Fixes: 2afbbab45c261a ("pinctrl: microchip-sgpio: update to support regmap")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> ---
...