linux-kernel - Re: [PATCH] mm/sparse: make mminit_validate_memmodel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfKT0hs5C7Mr015v@kernel.org>
Date:   Thu, 27 Jan 2022 14:45:06 +0200
From:   Mike Rapoport <rppt@...nel.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/sparse: make mminit_validate_memmodel_limits() static

On Thu, Jan 27, 2022 at 05:32:21PM +0800, Miaohe Lin wrote:
> It's only used in the sparse.c now. So we can make it static and further
> clean up the relevant code.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  mm/internal.h | 11 -----------
>  mm/sparse.c   |  2 +-
>  2 files changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/mm/internal.h b/mm/internal.h
> index 4c2d06a2f50b..927dfba5111f 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -572,17 +572,6 @@ static inline void mminit_verify_zonelist(void)
>  }
>  #endif /* CONFIG_DEBUG_MEMORY_INIT */
>  
> -/* mminit_validate_memmodel_limits is independent of CONFIG_DEBUG_MEMORY_INIT */
> -#if defined(CONFIG_SPARSEMEM)
> -extern void mminit_validate_memmodel_limits(unsigned long *start_pfn,
> -				unsigned long *end_pfn);
> -#else
> -static inline void mminit_validate_memmodel_limits(unsigned long *start_pfn,
> -				unsigned long *end_pfn)
> -{
> -}
> -#endif /* CONFIG_SPARSEMEM */
> -
>  #define NODE_RECLAIM_NOSCAN	-2
>  #define NODE_RECLAIM_FULL	-1
>  #define NODE_RECLAIM_SOME	0
> diff --git a/mm/sparse.c b/mm/sparse.c
> index d21c6e5910d0..952f06d8f373 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -126,7 +126,7 @@ static inline int sparse_early_nid(struct mem_section *section)
>  }
>  
>  /* Validate the physical addressing limitations of the model */
> -void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
> +static void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
>  						unsigned long *end_pfn)
>  {
>  	unsigned long max_sparsemem_pfn = 1UL << (MAX_PHYSMEM_BITS-PAGE_SHIFT);
> -- 
> 2.23.0
> 
> 

-- 
Sincerely yours,
Mike.