linux-kernel - Re: [PATCH 04/16] tools/include: Update atomic.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfKkkRNTA9qCmPTW@casper.infradead.org>
Date:   Thu, 27 Jan 2022 13:56:33 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Karolina Drobnik <karolinadrobnik@...il.com>
Cc:     linux-mm@...ck.org, akpm@...ux-foundation.org,
        mike.rapoport@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/16] tools/include: Update atomic.h header

On Thu, Jan 27, 2022 at 02:21:22PM +0100, Karolina Drobnik wrote:
> Add atomic_long_t typedef and atomic_long_set function so they
>  can be used in testing.
> 
> Signed-off-by: Karolina Drobnik <karolinadrobnik@...il.com>
> ---
>  tools/include/linux/atomic.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/include/linux/atomic.h b/tools/include/linux/atomic.h
> index 00a6c4ca562b..5d2431889606 100644
> --- a/tools/include/linux/atomic.h
> +++ b/tools/include/linux/atomic.h
> @@ -4,6 +4,10 @@
>  
>  #include <asm/atomic.h>
>  
> +typedef atomic_t atomic_long_t;

Given this:

typedef struct {
        int counter;
} atomic_t;

your definition seems wrong.  Why not add atomic_long_t to types.h,
adjacent to atomic_t?