[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqL77E+5ftqgHPdWQzfp98Oh3d=QZRQ8Z6v91OfSeprxig@mail.gmail.com>
Date: Thu, 27 Jan 2022 08:35:31 -0600
From: Rob Herring <robh@...nel.org>
To: Jerome Brunet <jbrunet@...libre.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Rohit kumar <rohitkr@...eaurora.org>,
Cheng-Yi Chiang <cychiang@...omium.org>,
Shengjiu Wang <shengjiu.wang@....com>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Jonathan Bakker <xc-racer2@...e.ca>,
Krzysztof Kozlowski <krzk@...nel.org>,
Linux-ALSA <alsa-devel@...a-project.org>,
devicetree@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: Centralize the 'sound-dai' definition
On Thu, Jan 27, 2022 at 3:05 AM Jerome Brunet <jbrunet@...libre.com> wrote:
>
>
> On Wed 26 Jan 2022 at 17:14, Rob Herring <robh@...nel.org> wrote:
>
> > 'sound-dai' is a common property, but has duplicate type definitions.
> > Create a new common definition to define the type and then update all
> > the other occurrences to just define how many entries there are just
> > like other phandle+arg properties.
> >
> > The constraints on the number of entries is based on the examples and
> > could be wrong.
> >
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> > Please ack, this depends on commit abf0fee97313 ("dt-bindings: Improve
> > phandle-array schemas") in my tree.
> > ---
> > .../bindings/sound/amlogic,gx-sound-card.yaml | 4 ++--
> > .../bindings/sound/google,sc7180-trogdor.yaml | 6 ++++--
> > .../bindings/sound/imx-audio-card.yaml | 7 +++++--
> > .../bindings/sound/qcom,sm8250.yaml | 10 +++++++---
> > .../bindings/sound/samsung,aries-wm8994.yaml | 5 +----
> > .../bindings/sound/samsung,midas-audio.yaml | 2 --
> > .../bindings/sound/samsung,odroid.yaml | 9 +++------
> > .../devicetree/bindings/sound/sound-dai.yaml | 20 +++++++++++++++++++
> > 8 files changed, 42 insertions(+), 21 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/sound/sound-dai.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
> > index 2e35aeaa8781..8b5be4b92f35 100644
> > --- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
> > +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml
> > @@ -57,7 +57,7 @@ patternProperties:
> > rate
> >
> > sound-dai:
> > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
> > description: phandle of the CPU DAI
> >
> > patternProperties:
> > @@ -71,7 +71,7 @@ patternProperties:
> >
> > properties:
> > sound-dai:
> > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > + maxItems: 1
>
> No min or max here. Links may have more than one codec.
>
> Ex:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts#n158
What do you mean? Every 'sound-dai' there only has 1 phande+args. Each
codec is a child node.
Rob
Powered by blists - more mailing lists