[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6cd58652-f24e-3919-589f-d71eb0e8070f@baylibre.com>
Date: Thu, 27 Jan 2022 16:17:57 +0100
From: Neil Armstrong <narmstrong@...libre.com>
To: Dongjin Kim <tobetter@...il.com>, Rob Herring <robh+dt@...nel.org>,
Kevin Hilman <khilman@...libre.com>,
Jerome Brunet <jbrunet@...libre.com>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO domain
for GPIOE_2
On 27/01/2022 16:16, Dongjin Kim wrote:
> GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of
> TF_PWR_EN of 'FC8731' on BPI-M5
>
> Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
>
> Signed-off-by: Dongjin Kim <tobetter@...il.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> index 212c6aa5a3b8..5751c48620ed 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts
> @@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
>
> - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
> + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> regulator-always-on;
>
>
Reviewed-by: Neil Armstrong <narmstrong@...libre.com>
Thanks !
Neil
Powered by blists - more mailing lists