linux-kernel - Re: [4.9 PATCH] ARM: 8800/1: use choice for kernel unwinders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfK7/goKdy5qlhEc@kroah.com>
Date:   Thu, 27 Jan 2022 16:36:30 +0100
From:   Greg KH <greg@...ah.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        Stefan Agner <stefan@...er.ch>, Arnd Bergmann <arnd@...db.de>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [4.9 PATCH] ARM: 8800/1: use choice for kernel unwinders

On Tue, Jan 25, 2022 at 02:41:48PM +0100, Anders Roxell wrote:
> From: Stefan Agner <stefan@...er.ch>
> 
> commit f9b58e8c7d031b0daa5c9a9ee27f5a4028ba53ac upstream.
> 
> While in theory multiple unwinders could be compiled in, it does
> not make sense in practise. Use a choice to make the unwinder
> selection mutually exclusive and mandatory.
> 
> Already before this commit it has not been possible to deselect
> FRAME_POINTER. Remove the obsolete comment.
> 
> Furthermore, to produce a meaningful backtrace with FRAME_POINTER
> enabled the kernel needs a specific function prologue:
>     mov    ip, sp
>     stmfd    sp!, {fp, ip, lr, pc}
>     sub    fp, ip, #4
> 
> To get to the required prologue gcc uses apcs and no-sched-prolog.
> This compiler options are not available on clang, and clang is not
> able to generate the required prologue. Make the FRAME_POINTER
> config symbol depending on !clang.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  arch/arm/Kconfig.debug | 44 +++++++++++++++++++++++++++---------------
>  lib/Kconfig.debug      |  6 +++---
>  2 files changed, 31 insertions(+), 19 deletions(-)

Now queued up, thanks.

greg k-h