linux-kernel - Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5b72f09-a208-a579-3e51-10935ccee1ff@linuxfoundation.org>
Date:   Fri, 28 Jan 2022 10:27:52 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Sean Young <sean@...s.org>
Cc:     kernel test robot <oliver.sang@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        lkp@...ts.01.org, kbuild test robot <lkp@...el.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [tools headers UAPI] e2bcbd7769: kernel-selftests.ir.make_fail

On 1/28/22 9:49 AM, Alexei Starovoitov wrote:
> On Fri, Jan 28, 2022 at 1:32 AM Sean Young <sean@...s.org> wrote:
>>

>>> ir_loopback.c: In function ‘main’:
>>> ir_loopback.c:147:20: error: ‘RC_PROTO_RCMM32’ undeclared (first use in this function); did you mean ‘RC_PROTO_RC6_MCE’?
>>>      if (rc_proto == RC_PROTO_RCMM32 &&
>>>                      ^~~~~~~~~~~~~~~
>>>                      RC_PROTO_RC6_MCE
>>
>> So this commit removes the copy of lirc.h from tools/include/uapi/linux/lirc.h,
>> so now the test uses /usr/include/linux/lirc.h. It appears that this file
>> does not have RC_PROTO_RCMM32 defined on this system, which means it is a
>> kernel header from v5.1 or earlier (this was added in commit
>> 721074b03411327e7bf41555d4cc7c18f49313f7).
>>
>> It looks like this machine is redhat 8.3, which ships with kernel 4.18.
>>
>> I guess my change was far too optimistic; I had no ideal enterprise kernels
>> were so ancient.
>>
>> We should probably drop e2bcbd7769ee8f05e1b3d10848aace98973844e4. Sorry about
>> the turbulence.
> 
> I'd rather avoid reverting.
> Just add ifdef or something to shut up the error on old distros.
> 

Sean,

Let's not add release checks.

Since RC_PROTO_RCMM32 is the only one missing, perhaps you could define
just that one in ir_loopback.c with a comment that it can be removed.

ifndef RC_PROTO_RCMM32 ---

thanks,
-- Shuah