linux-kernel - Re: [PATCH] net/switchdev: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfQzqqiw7O/iKUD0@lunn.ch>
Date:   Fri, 28 Jan 2022 19:19:22 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     cgel.zte@...il.com
Cc:     jiri@...nulli.us, ivecera@...hat.com, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] net/switchdev: use struct_size over open coded arithmetic

On Fri, Jan 28, 2022 at 07:57:29AM +0000, cgel.zte@...il.com wrote:
> From: "Minghao Chi (CGEL ZTE)" <chi.minghao@....com.cn>
> 
> Replace zero-length array with flexible-array member and make use
> of the struct_size() helper in kmalloc(). For example:
> 
> struct switchdev_deferred_item {
> 	...
> 	unsigned long data[];
> };
> 
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>

Please could you train your bot to zealously compile test patches
before submitting them?

At the moment you seem to have more patches which fail to build then
actually build. So you are wasting peoples time, which is not going to
make Maintainers happy.

       Andrew