linux-kernel - Re: [PATCH] scripts/get_abi.pl: Ignore hidden files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220128220007.085021a8@coco.lan>
Date:   Fri, 28 Jan 2022 22:00:59 +0100
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] scripts/get_abi.pl: Ignore hidden files

Em Fri, 28 Jan 2022 21:45:52 +0100
Jonathan Neuschäfer <j.neuschaefer@....net> escreveu:

> On Fri, Jan 28, 2022 at 09:13:53PM +0100, Jonathan Neuschäfer wrote:
> > get_abi.pl currently collects every file in Documentation/ABI. This
> > causes a UnicodeDecodeError in Documentation/sphinx/kernel_api.py,  
> 
> Ooops, this should be kernel_abi.py.
> 

After addressing your comment about the kernel_abi.py file, feel free
to add:

Reviewed-by: Mauro Carvalho Chehab <mchehab@...nel.org>

> 
> > when it finds my Vim swap files (.foo.swp) in the directory.
> > 
> > To avoid such issues, ignore hidden files in get_api.pl.  
> 
> ... and get_abi.pl.
> 
> 
> > 
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > ---
> >  scripts/get_abi.pl | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/scripts/get_abi.pl b/scripts/get_abi.pl
> > index 6212f58b69c61..47b7eca5b0b71 100755
> > --- a/scripts/get_abi.pl
> > +++ b/scripts/get_abi.pl
> > @@ -92,6 +92,7 @@ sub parse_abi {
> >  	my $mode = (stat($file))[2];
> >  	return if ($mode & S_IFDIR);
> >  	return if ($file =~ m,/README,);
> > +	return if ($file =~ m,/\.,);
> > 
> >  	my $name = $file;
> >  	$name =~ s,.*/,,;
> > --
> > 2.34.1

Thanks,
Mauro