linux-kernel - Re: [PATCH] arch:x86:pci:irq.c: Improve log message when IRQ cannot be identified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jan 2022 13:36:53 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     Brent Spillner <spillner@....org>
Cc:     bhelgaas@...gle.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch:x86:pci:irq.c: Improve log message when IRQ cannot
 be identified

On 1/28/22 12:48, Brent Spillner wrote:
> It seems like the multiline string literal is your main pain point--- would
> 
> +#ifdef CONFIG_ACPI
> +                       if (acpi_noirq)
> +                               msg = "; consider removing acpi=noirq";
> +                       else
> +                               msg = "; recommend verifying UEFI/BIOS
> IRQ options";
> +#else
> +                       msg = "; recommend verifying UEFI/BIOS IRQ
> options or enabling ACPI";
> +#endif
> 
> be OK without going to IS_ENABLED()?  (Personally, I think the #ifdef
> style is more readable.)

I think that's _better_ than what was in the patch.  But, even with it,
I still think the #ifdef mess borders on unreadable.

But, if Bjorn likes it, then go for it. :)