linux-kernel - [ammarfaizi2-block:tiwai/sound/topic/fw-loader-zstd-5.17 1/3] drivers/base/firmware_loader/main.c:326:16: warning: result of comparison of constant 18446744073709551614 with expression of type 'size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202201290700.RQlEvkeI-lkp@intel.com>
Date:   Sat, 29 Jan 2022 07:17:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...weeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:tiwai/sound/topic/fw-loader-zstd-5.17 1/3]
 drivers/base/firmware_loader/main.c:326:16: warning: result of comparison of
 constant 18446744073709551614 with expression of type 'size_t' (aka
 'unsigned int') is always false

tree:   https://github.com/ammarfaizi2/linux-block tiwai/sound/topic/fw-loader-zstd-5.17
head:   ed4bba5cc56e96fda12bd427e950da2d987c49c9
commit: d8649529852348bd245bfdc5cee97311c57cf73a [1/3] firmware: Add the support for ZSTD-compressed firmware files
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20220129/202201290700.RQlEvkeI-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45ee44b1f32ffdbc995e6fec806271b4b3ba4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/d8649529852348bd245bfdc5cee97311c57cf73a
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block tiwai/sound/topic/fw-loader-zstd-5.17
        git checkout d8649529852348bd245bfdc5cee97311c57cf73a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/base/firmware_loader/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/base/firmware_loader/main.c:326:16: warning: result of comparison of constant 18446744073709551614 with expression of type 'size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
                       out_size == ZSTD_CONTENTSIZE_ERROR) {
                       ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~
   drivers/base/firmware_loader/main.c:325:16: warning: result of comparison of constant 18446744073709551615 with expression of type 'size_t' (aka 'unsigned int') is always false [-Wtautological-constant-out-of-range-compare]
                   if (out_size == ZSTD_CONTENTSIZE_UNKNOWN ||
                       ~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +326 drivers/base/firmware_loader/main.c

   307	
   308	/*
   309	 * ZSTD-compressed firmware support
   310	 */
   311	#ifdef CONFIG_FW_LOADER_COMPRESS_ZSTD
   312	static int fw_decompress_zstd(struct device *dev, struct fw_priv *fw_priv,
   313				      size_t in_size, const void *in_buffer)
   314	{
   315		size_t len, out_size, workspace_size;
   316		void *workspace, *out_buf;
   317		zstd_dctx *ctx;
   318		int err;
   319	
   320		if (fw_priv->data) {
   321			out_size = fw_priv->allocated_size;
   322			out_buf = fw_priv->data;
   323		} else {
   324			out_size = zstd_find_frame_compressed_size(in_buffer, in_size);
   325			if (out_size == ZSTD_CONTENTSIZE_UNKNOWN ||
 > 326			    out_size == ZSTD_CONTENTSIZE_ERROR) {
   327				dev_dbg(dev, "%s: invalid decompression size\n", __func__);
   328				return -EINVAL;
   329			}
   330			out_buf = vzalloc(out_size);
   331			if (!out_buf)
   332				return -ENOMEM;
   333		}
   334	
   335		workspace_size = zstd_dctx_workspace_bound();
   336		workspace = kvzalloc(workspace_size, GFP_KERNEL);
   337		if (!workspace) {
   338			err = -ENOMEM;
   339			goto error;
   340		}
   341	
   342		ctx = zstd_init_dctx(workspace, workspace_size);
   343		if (!ctx) {
   344			dev_dbg(dev, "%s: failed to initialize context\n", __func__);
   345			err = -EINVAL;
   346			goto error;
   347		}
   348	
   349		len = zstd_decompress_dctx(ctx, out_buf, out_size, in_buffer, in_size);
   350		if (zstd_is_error(len)) {
   351			dev_dbg(dev, "%s: failed to decompress: %d\n", __func__,
   352				zstd_get_error_code(len));
   353			err = -EINVAL;
   354			goto error;
   355		}
   356	
   357		fw_priv->size = len;
   358		if (!fw_priv->data)
   359			fw_priv->data = out_buf;
   360		err = 0;
   361	
   362	 error:
   363		kvfree(workspace);
   364		if (!fw_priv->data)
   365			vfree(out_buf);
   366		return err;
   367	}
   368	#endif /* CONFIG_FW_LOADER_COMPRESS_ZSTD */
   369	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org