linux-kernel - Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56b761a-6cf9-23ab-c849-eff27e5e831e@linux-m68k.org>
Date:   Sat, 29 Jan 2022 10:45:53 +1100 (AEDT)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Tom Rix <trix@...hat.com>
cc:     Joe Perches <joe@...ches.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Miguel Ojeda <ojeda@...nel.org>, kashyap.desai@...adcom.com,
        sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com, nathan@...nel.org,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

On Fri, 28 Jan 2022, Tom Rix wrote:

> A testsuite for the fixers may help with churn
> 
> Any interest or thought on organization ?
> 

Here's one way:

1. Identify some source files that are exemplary (i.e. good style).
2. Run a new script to introduce style mistakes into those files.
3. Run the Reformatter Under Test on those files.
4. Compare the output with the original files.

But that's not sufficient to prevent more style patches (churn). We still 
need a way to avoid wasting everyone's time writing, submitting, reviewing 
and merging the inevitably incomplete style patches that may contain 
regressions and cause conflicts.

The tooling I would like to see is not a script to introduce style 
mistakes but an editor for binaries, such that C is not the "source" at 
all but only an ephemeral representation to make it easier for humans to 
effect changes to binaries (and debug info, commentary etc.)

Nonetheless, perfecting the clang-format tool is a good step towards a 
better workflow, which I described once before. 
https://lore.kernel.org/r/alpine.LNX.2.23.453.2010281344120.31@nippy.intranet/